c - Printing Sums within range for a Binary Search Tree -

-

i've got code working, reason isn't taking values of each node , adding them up. instead, output sum 0 each time. thought sum = sum + data line in btreesumrange method take care of this. idea how fix this?

  #include <stdio.h>   #include <stdlib.h>    static long long sum;    typedef struct node   {         long long data;       struct node *left;       struct node *right;   } node;   node * btreeinsert(node *node,long long data) {     if(node==null)     {         struct node *temp;         temp = (struct node *)malloc(sizeof(node));         temp -> data = data;         temp -> left = temp -> right = null;         return temp;     }      if(data >(node->data))     {         node->right = btreeinsert(node->right,data);     }     else if(data < (node->data))     {         node->left = btreeinsert(node->left,data);     }     return node;  }  void btreesumrange(node *tree, long long min,long long max) {     if (tree == null) {        return;     }     btreesumrange(tree->left, min, max);     long long data= tree->data;      if((data>=min)&&(data<=max)){         sum = sum + data;     }     btreesumrange(tree->right, min, max); }   int main() {      node *root;     long long value;     root = null;      file* data = fopen ("dataa", "r");     file* range = fopen ("rangea", "r");      while(fscanf(data, "%lld\n", &value) != eof){         printf("%lld\n", value);         btreeinsert(root, value);     }      long long min;     long long max;      while(fscanf(range, "%lld %lld\n", &min, &max) != eof){         btreesumrange(root, min, max);         printf("range [%lld,%lld]. sum = %lld. \n", min, max, sum);     }       return 0; }

you have 2 problems in code.

  1. at top level root not being set initial call of btreeinsert. btreeinsert(root, value); should root = btreeinsert(root, value);

  2. the malloc call using incorrect size:

    temp = (struct node *)malloc(sizeof(node));

    the confusion comes fact there both type named node , variable named node. , in line variable in scope. variable pointer sizeof(node) gives pointer size. want struct size not pointer size. suggest avoid such confusion in future not overloading type , variable names. 1 way fix change line following (no cast needed btw):

    temp = malloc(sizeof(*temp));


Comments

Post a Comment

Popular posts from this blog

java - Run spring boot application error: Cannot instantiate interface org.springframework.context.ApplicationListener -

-
i have spring project , try make use spring boot , run @ embadded tomcat following : https://spring.io/guides/gs/rest-service/ this application //@configuration //@enableaspectjautoproxy @springbootapplication @componentscan(basepackages = "gux.prome") public class application { public static void main(string[] args) { springapplication.run(application.class, args); } } if use maven command: mvn spring-boot:run , project starts fine, need debug , run main method @ intelij, exception occurs: exception in thread "main" java.lang.illegalargumentexception: cannot instantiate interface org.springframework.context.applicationlistener : org.springframework.boot.logging.classpathloggingapplicationlistener @ org.springframework.boot.springapplication.createspringfactoriesinstances(springapplication.java:414) @ org.springframework.boot.springapplication.getspringfactoriesinstances(springapplication.java:394) @ org.springframework.bo...
Read more

reactjs - React router and this.props.children - how to pass state to this.props.children -

-
i'm using react-router first time , don't know how think in yet. here's how i'm loading components in nested routes. entry point .js reactdom.render( <router history={hashhistory} > <route path="/" component={app}> <route path="models" component={content}> </route> </router>, document.getelementbyid('app') ); app.js render: function() { return ( <div> <header /> {this.props.children} </div> ); } so child of app content component sent in. i'm using flux , app.js has state , listens changes, don't know how pass state down this.props.children. before using react-router app.js defines children explicitly, passing state natural don't see how now. using couple of react helper methods can add state, props , whatever else this.props.children render: function() { var children = react.ch...
Read more

Excel VBA "Microsoft Windows Common Controls 6.0 (SP6)" Location Changes -

-
i have excel workbook used generate quotations customers. there main page user inputs data, , there buttons generate various pdfs , send them customer. however, 1 user consistently getting error preventing generating , sending pdfs. i beleive "microsoft windows common controls 6.0 (sp6)". it's installed on users' computers. on mine, location "c:\windows\syswow64\mscomctl.ocx" on others "c:\windows\system32\mscomctl.ocx" the user experiencing issues on 32-bit machine, "mscomctl.ocx" file should in system32. have manually put in there, , pointed common controls reference in vba it. issue seems keep reverting looking in syswow64. since folder doesn't exist, can't find it, , can't produce pdfs. i thought perhaps issue user running older version of office (2007) there users on 2013 , 2016. thought perhaps mixture of 64-bit , 32-bit users. user gets sent workbook other users (as quotation process goes further, gets passed ...
Read more