Teamcity build on every git commit vs build on pull request -

-

we setting teamcity our project uses git. have debate on if should trigger build on every commit or on every pull request.

if push branch a, , have configured build on pull request on master build triggered on how merged code appear or build branch ?

lets imagine have configures our teamcity build every pull request

now lets have branch master, developer checksout branch ftb_a. creates new test case , commits. developer code not yet merged master. develope b creates new branch ftb_b creates new test case. developer pushes branch , raises pull request build runs test case added develope runs. pull request developer merged , newly created tesr case available in master now.

now developer b pushes branch, has not rebased branch i.e. test case added developer not available in brach ftb_b. developer b raises pull request. build triggered. question when build triggered pull request raised developer b test case added developer in master run or not

though not indicated, i'm going assume using github here.

in short: yes, pull request ftb_b updated time changes pushed master. however, must trigger build on pull request branch, not on ftb_b itself.

to explain: when pull request ftb_b created, github generate new (hidden) branch consists of changes ftb_b merged tip of master. enables review changes, run teamcity builds against , perform other steps might want before accepting pull request. if pull request ftb_a accepted before creation of pull request ftb_b, these changes naturally included in pull request branch. if pull request ftb_a accepted after creation of pull request ftb_b, github detect change in master branch , update pull request branch you. in either case.

the flow might this:

  1. ftb_a pull request created
  2. ftb_a pull request branch created automatically github
  3. ftb_b pull request created
  4. ftb_b pull request branch created automatically github
    • this branch not include changes ftb_a @ point
  5. ftb_a pull request accepted
  6. master updated
  7. ftb_b pull request branch updated automatically github
    • now changes ftb_a reflected in pull request branch

check out more info:
https://blog.jetbrains.com/teamcity/2013/02/automatically-building-pull-requests-from-github-with-teamcity/


Comments

Post a Comment

Popular posts from this blog

java - Run spring boot application error: Cannot instantiate interface org.springframework.context.ApplicationListener -

-
i have spring project , try make use spring boot , run @ embadded tomcat following : https://spring.io/guides/gs/rest-service/ this application //@configuration //@enableaspectjautoproxy @springbootapplication @componentscan(basepackages = "gux.prome") public class application { public static void main(string[] args) { springapplication.run(application.class, args); } } if use maven command: mvn spring-boot:run , project starts fine, need debug , run main method @ intelij, exception occurs: exception in thread "main" java.lang.illegalargumentexception: cannot instantiate interface org.springframework.context.applicationlistener : org.springframework.boot.logging.classpathloggingapplicationlistener @ org.springframework.boot.springapplication.createspringfactoriesinstances(springapplication.java:414) @ org.springframework.boot.springapplication.getspringfactoriesinstances(springapplication.java:394) @ org.springframework.bo...
Read more

reactjs - React router and this.props.children - how to pass state to this.props.children -

-
i'm using react-router first time , don't know how think in yet. here's how i'm loading components in nested routes. entry point .js reactdom.render( <router history={hashhistory} > <route path="/" component={app}> <route path="models" component={content}> </route> </router>, document.getelementbyid('app') ); app.js render: function() { return ( <div> <header /> {this.props.children} </div> ); } so child of app content component sent in. i'm using flux , app.js has state , listens changes, don't know how pass state down this.props.children. before using react-router app.js defines children explicitly, passing state natural don't see how now. using couple of react helper methods can add state, props , whatever else this.props.children render: function() { var children = react.ch...
Read more

Excel VBA "Microsoft Windows Common Controls 6.0 (SP6)" Location Changes -

-
i have excel workbook used generate quotations customers. there main page user inputs data, , there buttons generate various pdfs , send them customer. however, 1 user consistently getting error preventing generating , sending pdfs. i beleive "microsoft windows common controls 6.0 (sp6)". it's installed on users' computers. on mine, location "c:\windows\syswow64\mscomctl.ocx" on others "c:\windows\system32\mscomctl.ocx" the user experiencing issues on 32-bit machine, "mscomctl.ocx" file should in system32. have manually put in there, , pointed common controls reference in vba it. issue seems keep reverting looking in syswow64. since folder doesn't exist, can't find it, , can't produce pdfs. i thought perhaps issue user running older version of office (2007) there users on 2013 , 2016. thought perhaps mixture of 64-bit , 32-bit users. user gets sent workbook other users (as quotation process goes further, gets passed ...
Read more